r104349 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104348‎ | r104349 | r104350 >
Date:17:27, 27 November 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
follow-up r104347: doesn't seem to change anything, but no other function in the class is called statically, so I'll keep it consistent
Modified paths:
  • /trunk/extensions/CentralAuth/specials/SpecialCentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/specials/SpecialCentralAuth.php
——@@ -698,7 +698,7 @@
699699 function determineHomeWiki() {
700700 foreach ( $this->mAttachedLocalAccounts as $wiki => $acc ) {
701701 if ( $acc['attachedMethod'] == 'primary' || $acc['attachedMethod'] == 'new' ) {
702 - return self::foreignUserLink( $wiki );
 702+ return $this->foreignUserLink( $wiki );
703703 }
704704 }
705705

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104347* (bug 23280) Show servername instead of dbname for home wiki on Special:Cent...robin17:20, 27 November 2011

Comments

#Comment by Johnduhart (talk | contribs)   17:33, 27 November 2011

Yes, don't call non-static functions statically.

Status & tagging log