r104264 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104263‎ | r104264 | r104265 >
Date:07:50, 26 November 2011
Author:amire80
Status:resolved (Comments)
Tags:
Comment:
Added gom-deva; sorted brx.
Modified paths:
  • /trunk/extensions/Narayam/Narayam.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/Narayam.php
——@@ -61,15 +61,19 @@
6262 'bn-inscript' => 'ext.narayam.rules.bn-inscript',
6363 'bn-nkb' => 'ext.narayam.rules.bn-nkb',
6464 ),
 65+ 'brx' => array(
 66+ 'brx-inscript' => 'ext.narayam.rules.brx-inscript',
 67+ ),
6568 'de' => array(
6669 'de' => 'ext.narayam.rules.de',
6770 ),
68 - 'brx' => array(
69 - 'brx-inscript' => 'ext.narayam.rules.brx-inscript',
70 - ),
7171 'eo' => array(
7272 'eo' => 'ext.narayam.rules.eo',
7373 ),
 74+ 'gom-deva' => array(
 75+ 'mr' => 'ext.narayam.rules.mr',
 76+ 'mr-inscript' => 'ext.narayam.rules.mr',
 77+ ),
7478 'hi' => array(
7579 'hi' => 'ext.narayam.rules.hi',
7680 'hi-inscript' => 'ext.narayam.rules.hi-inscript',

Follow-up revisions

RevisionCommit summaryAuthorDate
r104963Add Goan Konkani- Devanagari(gom-deva) input methods. Keymaps are same as hindi....santhosh11:51, 2 December 2011

Comments

#Comment by Santhosh.thottingal (talk | contribs)   05:05, 29 November 2011

+ 'mr' => 'ext.narayam.rules.mr',

+ 'mr-inscript' => 'ext.narayam.rules.mr',

The mr and mr-inscript keys cannot be reused since it has associated messages('Marathi Transliteration' and 'Marathi Inscript'). But if you change that to something like gom-dev, gom-dev-inscript, the schemes will not get loaded since the ext.narayam.rules.mr.js has the scheme name defined as mr.

#Comment by Amire80 (talk | contribs)   07:29, 29 November 2011

It was a quick fix for the hackathon to make Narayam work when the interface language is gom-deva, and it seems to work, although with a title that has a name of a different language in it.

A more structured way for sharing mappings between languages is needed, as i wrote at Extension talk:Narayam. Until something clever is done, the ability to set a custom title may suffice.

#Comment by Santhosh.thottingal (talk | contribs)   04:10, 6 December 2011

r104963 corrected this

Status & tagging log