r104265 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104264‎ | r104265 | r104266 >
Date:07:56, 26 November 2011
Author:petrb
Status:deferred
Tags:
Comment:
Fixed missing variable definition + reworded
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.i18n.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.status.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.i18n.php
@@ -19,7 +19,7 @@
2020 // Status bar text line (User is now Offline) etc.
2121 'onlinestatusbar-line' => '$1 is now $2 $3',
2222 // Message in config asking user if they want to enable it
23 - 'onlinestatusbar-used' => 'Do you want to let others see if you are online?',
 23+ 'onlinestatusbar-used' => 'Display your online status on your user pages',
2424 // Message in config asking what status they want to use
2525 'onlinestatusbar-status' => 'What is the default status you wish to use:',
2626 // Message in config asking if user wants to purge the user page
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.status.php
@@ -78,15 +78,14 @@
7979 }
8080 else {
8181 $result = self::getCache( $user->getName(), "d" );
82 -
8382 if ( $result == '' ) {
8483 $dbr = wfGetDB( DB_SLAVE );
8584 $result = $dbr->selectField( 'online_status', 'timestamp', array( 'username' => $user->getName() ),
8685 __METHOD__, array( 'LIMIT 1', 'ORDER BY timestamp DESC' ) );
87 - $w_time = OnlineStatusBar::getTimeoutDate( true );
8886 // cache it
8987 self::setCache( $user->getName(), $result, "d" );
9088 }
 89+ $w_time = OnlineStatusBar::getTimeoutDate( true );
9190 }
9291
9392 if ( $result === false ) {

Status & tagging log