r104242 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104241‎ | r104242 | r104243 >
Date:16:28, 25 November 2011
Author:jeroendedauw
Status:reverted (Comments)
Tags:
Comment:
fix js issue
Modified paths:
  • /trunk/extensions/Reviews/resources/jquery.reviewControl.js (modified) (history)
  • /trunk/extensions/Reviews/resources/reviews.pager.js (modified) (history)
  • /trunk/extensions/Reviews/resources/reviews.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Reviews/resources/jquery.reviewControl.js
@@ -29,6 +29,10 @@
3030 for ( rating in ratings ) {
3131 if ( ratings.hasOwnProperty( rating ) ) {
3232 $tr.append( $( '<td>' ).append(
 33+ $( '<label>' ).attr( {
 34+ 'for': this.fieldName( 'ratingdiv' + rating ),
 35+ 'class': 'review-ratings-label'
 36+ } ).text( rating ),
3337 $( '<div>' )
3438 .attr( {
3539 'id': this.fieldName( 'ratingdiv' + rating ),
@@ -43,10 +47,7 @@
4448 'id': this.fieldName( 'rating' + rating ),
4549 'class': 'review-specificratinginput'
4650 }
47 - ) ).prepend( $( '<label>' ).attr( {
48 - 'for': this.fieldName( 'ratingdiv' + rating ),
49 - 'class': 'review-ratings-label'
50 - } ).text( rating ) )
 51+ ) )
5152 )
5253 );
5354 }
@@ -105,10 +106,11 @@
106107 ).append( '<br>' );
107108
108109 $this.append(
109 - this.ratingInput.prepend( $( '<label>' ).attr( {
 110+ $( '<label>' ).attr( {
110111 'for': this.fieldName( 'rating' ),
111112 'class': 'review-rating-label'
112 - } ).text( mw.msg( 'reviews-submission-rating' ) ) )
 113+ } ).text( mw.msg( 'reviews-submission-rating' ) ),
 114+ this.ratingInput
113115 );
114116
115117 $this.append( this.ratingsInput );
Index: trunk/extensions/Reviews/resources/reviews.pager.js
@@ -10,7 +10,9 @@
1111
1212 $( document ).ready( function() {
1313
14 - $( '.reviews-state-controls' ).reviewState();
 14+ $.each( $( '.reviews-state-controls' ), function( i, e ) {
 15+ $( e ).reviewState();
 16+ } );
1517
1618 } );
1719
Index: trunk/extensions/Reviews/resources/reviews.special.js
@@ -10,7 +10,9 @@
1111
1212 $( document ).ready( function() {
1313
14 - $( '.reviews-state-controls' ).reviewState();
 14+ $.each( $( '.reviews-state-controls' ), function( i, e ) {
 15+ $( e ).reviewState();
 16+ } );
1517
1618 } );
1719

Comments

#Comment by Jeroen De Dauw (talk | contribs)   19:08, 25 November 2011

Double 42!

Status & tagging log