r104206 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104205‎ | r104206 | r104207 >
Date:00:06, 25 November 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fix syntax error from r104041
Modified paths:
  • /trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php
@@ -30,7 +30,7 @@
3131 // the nonexistent cache file for en a couple hundred times
3232 continue;
3333 }
34 -
 34+
3535 $cache['messages'] = array_merge(
3636 $cache['messages'],
3737 self::readFile( $code )
@@ -455,7 +455,7 @@
456456 //foreach ( $changedStrings as $key => $value ) {
457457 // HACK for r103763 CR: store all messages, even unchanged ones
458458 // TODO this file is a mess and needs to be rewritten
459 - foreach ( array_merge( array_keys( $base_messages, $compare_messages ) as $key ) {
 459+ foreach ( array_merge( array_keys( $base_messages ), $compare_messages ) as $key ) {
460460 // Only update the translation if this message wasn't changed in English
461461 if ( !isset( $forbiddenKeys[$key] ) && isset( $base_messages[$key] ) ) {
462462 $new_messages[$key] = $base_messages[$key];

Follow-up revisions

RevisionCommit summaryAuthorDate
r104233Followup r104206: make it do what I intended it to docatrope11:37, 25 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104041Followup r103763: per Liangent's CR comment, there was a bug where an unchang...catrope15:05, 23 November 2011

Comments

#Comment by Reedy (talk | contribs)   00:09, 25 November 2011

Fixes

<mw-jenkinsbot> Project MediaWiki-lint build #48: STILL FAILING in 2 min 5 sec: [http://integration.mediawiki.org/ci/job/MediaWiki-lint/48/ http://integration.mediawiki.org/ci/job/MediaWiki-lint/48/]

Status & tagging log