r104233 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104232‎ | r104233 | r104234 >
Date:11:37, 25 November 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r104206: make it do what I intended it to do
Modified paths:
  • /trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php
@@ -455,7 +455,7 @@
456456 //foreach ( $changedStrings as $key => $value ) {
457457 // HACK for r103763 CR: store all messages, even unchanged ones
458458 // TODO this file is a mess and needs to be rewritten
459 - foreach ( array_merge( array_keys( $base_messages ), $compare_messages ) as $key ) {
 459+ foreach ( array_merge( array_keys( $base_messages ), array_keys( $compare_messages ) ) as $key ) {
460460 // Only update the translation if this message wasn't changed in English
461461 if ( !isset( $forbiddenKeys[$key] ) && isset( $base_messages[$key] ) ) {
462462 $new_messages[$key] = $base_messages[$key];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104206Fix syntax error from r104041reedy00:06, 25 November 2011

Status & tagging log