r104189 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104188‎ | r104189 | r104190 >
Date:19:31, 24 November 2011
Author:jeroendedauw
Status:reverted (Comments)
Tags:
Comment:
work on review pager
Modified paths:
  • /trunk/extensions/Reviews/Reviews.i18n.php (modified) (history)
  • /trunk/extensions/Reviews/includes/ReviewPager.php (modified) (history)
  • /trunk/extensions/Reviews/specials/SpecialMyReviews.php (modified) (history)
  • /trunk/extensions/Reviews/specials/SpecialReviews.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Reviews/Reviews.i18n.php
@@ -68,6 +68,9 @@
6969 'reviews-myreviews-editheader' => 'On this page you can edit your review. You can also view a list of [[Special:MyReviews|reviews you posted]].',
7070
7171 // Special:Reviews
 72+ 'reviews-reviews-header' => 'This page lists all reviews posted on this wiki',
 73+ 'reviews-reviews-nosuchreview' => 'You do not have a review with the provided ID, it might have been deleted. All reviews are listed below.',
 74+ 'reviews-reviews-editheader' => 'On this page you can manage this review. You can also view a list of [[Special:Reviews|all reviews]].',
7275
7376 // Review pager
7477 'reviews-pager-no-results' => 'There are no reviews to list.',
@@ -77,6 +80,7 @@
7881 'reviews-pager-user' => 'User',
7982 'reviews-pager-page' => 'For page',
8083 'reviews-pager-rating' => 'Rating',
 84+ 'reviews-pager-deleted' => 'The page was deleted',
8185 );
8286
8387 /** Message documentation (Message documentation)
Index: trunk/extensions/Reviews/specials/SpecialMyReviews.php
@@ -61,7 +61,7 @@
6262 else {
6363 $review = Review::selectRow( null, array( 'id' => $subPage, 'user_id' => $this->getUser()->getId() ) );
6464
65 - if ( $review == false ) {
 65+ if ( $review === false ) {
6666 $this->getOutput()->addWikiMsg( 'reviews-myreviews-nosuchreview' );
6767 $this->displayReviewList();
6868 }
Index: trunk/extensions/Reviews/specials/SpecialReviews.php
@@ -21,7 +21,7 @@
2222 * @since 0.1
2323 */
2424 public function __construct() {
25 - parent::__construct( 'Reviews', 'postreview' );
 25+ parent::__construct( 'Reviews', 'reviewsadmin' );
2626 }
2727
2828 /**
@@ -54,19 +54,29 @@
5555 return false;
5656 }
5757
58 - if ( $this->getRequest()->wasPosted() ) {
59 -
 58+ if ( $subPage === '' ) {
 59+ $this->getOutput()->addWikiMsg( 'reviews-reviews-header' );
 60+ $this->displayReviewList();
6061 }
6162 else {
62 - if ( $subPage === '' ) {
 63+ $review = Review::selectRow( null, array( 'id' => $subPage ) );
 64+
 65+ if ( $review === false ) {
 66+ $this->getOutput()->addWikiMsg( 'reviews-reviews-nosuchreview' );
6367 $this->displayReviewList();
6468 }
6569 else {
66 - // TODO
 70+ $this->getOutput()->addWikiMsg( 'reviews-reviews-editheader' );
 71+ $this->displayEditControl( $review );
6772 }
6873 }
6974 }
7075
 76+ /**
 77+ * Display the list of reviews.
 78+ *
 79+ * @since 0.1
 80+ */
7181 protected function displayReviewList() {
7282 $reviewPager = new ReviewPager( array() );
7383
Index: trunk/extensions/Reviews/includes/ReviewPager.php
@@ -113,19 +113,12 @@
114114 break;
115115 case 'review_page_id':
116116 $title = Title::newFromID( $value );
117 - $value = Html::element(
118 - 'a',
119 - array( 'href' => $title->getLocalURL() ),
120 - $title->getFullText()
121 - );
 117+ $value = is_null( $title ) ? wfMsg( 'reviews-pager-deleted' ) : Linker::link( $title );
122118 break;
123119 case 'review_user_id':
124 - $title = User::newFromId( $value )->getUserPage();
125 - $value = Html::element(
126 - 'a',
127 - array( 'href' => $title->getLocalURL() ),
128 - $title->getFullText()
129 - );
 120+ $user = User::newFromId( $value );
 121+ $value = Linker::userLink( $user->getId(), $user->getName() ) .
 122+ Linker::userToolLinks( $user->getId(), $user->getName() );
130123 break;
131124 case 'review_title':
132125 if ( $this->editPage !== false ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r104199qqq docs, follow up to r104189 r104188 r104176jeroendedauw21:56, 24 November 2011

Comments

#Comment by Siebrand (talk | contribs)   20:20, 24 November 2011

Please add message documentation for the newly added messages. Thanks.

Status & tagging log