r104188 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104187‎ | r104188 | r104189 >
Date:19:01, 24 November 2011
Author:jeroendedauw
Status:reverted (Comments)
Tags:
Comment:
added rating field to pager
Modified paths:
  • /trunk/extensions/Reviews/Reviews.i18n.php (modified) (history)
  • /trunk/extensions/Reviews/includes/ReviewPager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Reviews/includes/ReviewPager.php
@@ -82,6 +82,7 @@
8383 }
8484
8585 $headers['review_state'] = 'reviews-pager-state';
 86+ $headers['review_rating'] = 'reviews-pager-rating';
8687
8788 $headers = array_map( 'wfMsg', $headers );
8889 }
@@ -135,6 +136,10 @@
136137 );
137138 }
138139 break;
 140+ case 'review_rating':
 141+ // TODO: might want to display stars here as well.
 142+ $value = $this->getLang()->formatNum( $value );
 143+ break;
139144 }
140145
141146 return $value;
@@ -150,6 +155,7 @@
151156 'review_title',
152157 'review_user_id',
153158 'review_page_id',
 159+ 'review_rating',
154160 ),
155161 'conds' => $this->conds,
156162 );
@@ -173,6 +179,7 @@
174180 array(
175181 'review_post_time',
176182 'review_state',
 183+ 'review_rating',
177184 )
178185 );
179186 }
Index: trunk/extensions/Reviews/Reviews.i18n.php
@@ -76,6 +76,7 @@
7777 'reviews-pager-title' => 'Title',
7878 'reviews-pager-user' => 'User',
7979 'reviews-pager-page' => 'For page',
 80+ 'reviews-pager-rating' => 'Rating',
8081 );
8182
8283 /** Message documentation (Message documentation)

Follow-up revisions

RevisionCommit summaryAuthorDate
r104199qqq docs, follow up to r104189 r104188 r104176jeroendedauw21:56, 24 November 2011

Comments

#Comment by Siebrand (talk | contribs)   20:21, 24 November 2011

Please add message documentation for the newly added messages. Thanks.

Status & tagging log