r104162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104161‎ | r104162 | r104163 >
Date:13:51, 24 November 2011
Author:catrope
Status:ok
Tags:
Comment:
Use INSERT IGNORE in GlobalUsage::copyLocalImagelinks(), was throwing DB errors on Commons. The other insert() calls already have IGNORE set.
Modified paths:
  • /trunk/extensions/GlobalUsage/GlobalUsage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalUsage/GlobalUsage_body.php
——@@ -112,7 +112,7 @@
113113 'gil_to' => $row->il_to,
114114 );
115115 }
116 - $this->db->insert( 'globalimagelinks', $insert, __METHOD__ );
 116+ $this->db->insert( 'globalimagelinks', $insert, __METHOD__, array( 'IGNORE' ) );
117117 }
118118
119119 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r1041631.18wmf1: MFT r104162catrope13:52, 24 November 2011
r104178REL1_18 MFT r100516, r103675, r104049, r104162reedy16:20, 24 November 2011

Status & tagging log