r103675 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103674‎ | r103675 | r103676 >
Date:14:03, 19 November 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Fix notice in LiquidThreads caused by $_SESSION not being defined if session_start() hasn't been called
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -359,7 +359,7 @@
360360 * @param $request FauxRequest object to have session data injected into.
361361 */
362362 static function fixFauxRequestSession( $request ) {
363 - foreach( $_SESSION as $k => $v ) {
 363+ foreach( (array)$_SESSION as $k => $v ) {
364364 $request->setSessionData( $k, $v );
365365 }
366366 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r1036761.18wmf1: MFT r103675catrope14:04, 19 November 2011
r104178REL1_18 MFT r100516, r103675, r104049, r104162reedy16:20, 24 November 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   21:47, 23 November 2011

Deployed to 1.18wmf1, please consider tagging for 1.18

Status & tagging log