r104085 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104084‎ | r104085 | r104086 >
Date:21:01, 23 November 2011
Author:johnduhart
Status:resolved (Comments)
Tags:
Comment:
Followup r100722, show the full size of the page in the tooltip
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
——@@ -216,8 +216,10 @@
217217 $formattedSizeClass = 'mw-plusminus-neg';
218218 }
219219
 220+ $formattedTotalSize = wfMsgExt( 'nbytes', 'parsemag', $wgLang->formatNum( $new ) );
 221+
220222 return Html::element( $tag,
221 - array( 'dir' => 'ltr', 'class' => $formattedSizeClass ),
 223+ array( 'dir' => 'ltr', 'class' => $formattedSizeClass, 'title' => $formattedTotalSize ),
222224 wfMessage( 'parentheses', $formattedSize )->plain() ) . $wgLang->getDirMark();
223225 }
224226

Follow-up revisions

RevisionCommit summaryAuthorDate
r108017enhance size tooltip on changelist...hashar11:33, 4 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100722* Removed $wgRCShowChangedSize check in sp:Contributions for size diffs since...aaron18:19, 25 October 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   21:10, 23 November 2011

I love it. :)

#Comment by Nikerabbit (talk | contribs)   08:22, 24 November 2011

It's not obvious that the size in tooltip is the full page size - it took me a while to discover it is just not the bytechange repeated with unit.

#Comment by Hashar (talk | contribs)   11:33, 4 January 2012

Enhanced with r108017

Status & tagging log