r108017 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108016‎ | r108017 | r108018 >
Date:11:33, 4 January 2012
Author:hashar
Status:ok
Tags:
Comment:
enhance size tooltip on changelist

follow r104085
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1225,6 +1225,7 @@
12261226 'rc_categories',
12271227 'rc_categories_any',
12281228 'rc-change-size',
 1229+ 'rc-change-size-new',
12291230 'newsectionsummary',
12301231 'rc-enhanced-expand',
12311232 'rc-enhanced-hide',
Index: trunk/phase3/includes/ChangesList.php
@@ -217,7 +217,7 @@
218218 $formattedSizeClass = 'mw-plusminus-neg';
219219 }
220220
221 - $formattedTotalSize = wfMsgExt( 'nbytes', 'parsemag', $wgLang->formatNum( $new ) );
 221+ $formattedTotalSize = wfMsgExt( 'rc-change-size-new', 'parsemag', $wgLang->formatNum( $new ) );
222222
223223 return Html::element( $tag,
224224 array( 'dir' => 'ltr', 'class' => $formattedSizeClass, 'title' => $formattedTotalSize ),
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -1780,6 +1780,7 @@
17811781 'rc-change-size' => '{{optional}}
17821782
17831783 Does not work under $wgMiserMode ([[mwr:48986|r48986]]).',
 1784+'rc-change-size-new' => 'Tooltip when overing a change list diff size. The tooltip show the resulting new size in bytes.',
17841785 'newsectionsummary' => 'Default summary when adding a new section to a page.',
17851786
17861787 # Recent changes linked
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2061,6 +2061,8 @@
20622062 'rc_categories' => 'Limit to categories (separate with "|")',
20632063 'rc_categories_any' => 'Any',
20642064 'rc-change-size' => '$1', # only translate this message to other languages if you have to change it
 2065+'rc-change-size-new' => '$1 {{PLURAL:$1|byte|bytes}} after change',
 2066+
20652067 'newsectionsummary' => '/* $1 */ new section',
20662068 'rc-enhanced-expand' => 'Show details (requires JavaScript)',
20672069 'rc-enhanced-hide' => 'Hide details',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104085Followup r100722, show the full size of the page in the tooltipjohnduhart21:01, 23 November 2011

Status & tagging log