r103669 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103668‎ | r103669 | r103670 >
Date:13:36, 19 November 2011
Author:reedy
Status:ok
Tags:
Comment:
4 PHP Warning: array_merge() [<a href='function.array-merge'>function.array-merge</a>]: Argument #2 is not an array in /usr/local/apache/common-local/php-1.18/extensions/CentralAuth/CentralAuthUser.php on line 1518

In trunk at 1578
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuthUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuthUser.php
@@ -1573,10 +1573,15 @@
15741574 'attachedMethod' => $row->lu_attached_method,
15751575 );
15761576
 1577+ $localUser = $this->localUserData( $row->lu_wiki );
 1578+
 1579+ if ( $localUser === false ) {
 1580+ continue;
 1581+ }
15771582 // Just for fun, add local user data.
15781583 // Displayed in the steward interface.
15791584 $wikis[$row->lu_wiki] = array_merge( $wikis[$row->lu_wiki],
1580 - $this->localUserData( $row->lu_wiki ) );
 1585+ $localUser );
15811586 }
15821587
15831588 return $wikis;
@@ -1608,7 +1613,7 @@
16091614 * Fetch a row of user data needed for migration.
16101615 *
16111616 * @param $wikiID String
1612 - * @return Array
 1617+ * @return Array|bool
16131618 */
16141619 protected function localUserData( $wikiID ) {
16151620 $lb = wfGetLB( $wikiID );

Follow-up revisions

RevisionCommit summaryAuthorDate
r103671MFT r103669reedy13:39, 19 November 2011

Status & tagging log