r103630 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103629‎ | r103630 | r103631 >
Date:00:47, 19 November 2011
Author:khorn
Status:reverted
Tags:
Comment:
Deploy-only change, for the lightweight variable constraint system (that will go away as soon as we rejoin the real world in Dev).
Modified paths:
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -1536,6 +1536,7 @@
15371537 'street',
15381538 'city',
15391539 'state',
 1540+ 'zip',
15401541 'email',
15411542 'amount',
15421543 'card_type',
@@ -1574,6 +1575,11 @@
15751576 $this->staged_data['state'] = substr( $this->staged_data['state'], 0, 35 );
15761577 }
15771578
 1579+ protected function stage_zip( $type = 'request' ) {
 1580+ // Truncate to 10 characters due to GlobalCollect's field length limit
 1581+ $this->staged_data['zip'] = substr( $this->staged_data['zip'], 0, 10 );
 1582+ }
 1583+
15781584 protected function stage_email( $type = 'request' ) {
15791585 // Truncate to 70 characters due to GlobalCollect's field length limit
15801586 $this->staged_data['email'] = substr( $this->staged_data['email'], 0, 70 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r103830Preliminary merge for 11/21 deployment....khorn20:22, 21 November 2011

Status & tagging log