r103631 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103630‎ | r103631 | r103632 >
Date:01:49, 19 November 2011
Author:asher
Status:deferred
Tags:
Comment:
exception handing in profiler-to-carbon, for when collector has no data
Modified paths:
  • /trunk/udpprofile/debian/changelog (modified) (history)
  • /trunk/udpprofile/profiler-to-carbon (modified) (history)

Diff [purge]

Index: trunk/udpprofile/debian/changelog
@@ -1,3 +1,9 @@
 2+udpprofile (1.2-2) lucid-wikimedia; urgency=low
 3+
 4+ * exception handing in profiler-to-carbon, for when collector has no data
 5+
 6+ -- Asher Feldman <afeldman@wikimedia.org> Fri, 19 Nov 2011 01:48:00 +0000
 7+
28 udpprofile (1.2-1) lucid-wikimedia; urgency=low
39
410 * collector now stores a cyclic buffer of sample times
Index: trunk/udpprofile/profiler-to-carbon
@@ -109,7 +109,13 @@
110110 time.sleep(delay)
111111 continue
112112
113 - fullprofile=ExtractProfile().extract(profsock)
 113+ try:
 114+ fullprofile=ExtractProfile().extract(profsock)
 115+ except Exception as detail:
 116+ logging.debug ("failed extracting data from collector: %s", detail)
 117+ time.sleep(delay)
 118+ continue
 119+
114120 profsock.shutdown(socket.SHUT_RDWR)
115121 profsock.close()
116122

Status & tagging log