r103626 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103625‎ | r103626 | r103627 >
Date:23:30, 18 November 2011
Author:kaldari
Status:ok
Tags:
Comment:
disabling timezone stuff for now
Modified paths:
  • /trunk/extensions/ContributionReporting/ContributionReporting.php (modified) (history)
  • /trunk/extensions/ContributionReporting/FundraiserStatistics_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContributionReporting/ContributionReporting.php
@@ -103,10 +103,9 @@
104104 $egFundraiserStatisticsMaximum = 10000;
105105
106106 // Cache timeout for fundraiser statistics, in seconds
107 -$egFundraiserStatisticsCacheTimeout = 300; // 5 minutes
 107+$egFundraiserStatisticsCacheTimeout = 900; // 15 minutes
108108
109109
110 -
111110 $wgContributionTrackingStatisticsViewWeeks = 3;
112111
113112 $wgHooks['ParserFirstCallInit'][] = 'efContributionReportingSetup';
Index: trunk/extensions/ContributionReporting/FundraiserStatistics_body.php
@@ -22,7 +22,12 @@
2323 if ( $wgRequest->wasPosted() ) {
2424 $showYear[$fundraiser['id']] = $wgRequest->getCheck( 'toogle'.$fundraiser['id'] );
2525 } else {
26 - $showYear[$fundraiser['id']] = true;
 26+ // By default, show only the fundraising years after 2008
 27+ if ( intval( $fundraiser['id'] ) > 2008 ) {
 28+ $showYear[$fundraiser['id']] = true;
 29+ } else {
 30+ $showYear[$fundraiser['id']] = false;
 31+ }
2732 }
2833 }
2934
@@ -205,8 +210,9 @@
206211 }
207212 $wgOut->addHTML( Xml::openElement( 'div', array( 'id' => 'configholder' ) ) );
208213 $wgOut->addHTML( $years );
209 - $wgOut->addHTML( wfMsg( 'fundraiserstats-time-zone' ).'<br/>' );
210 - $wgOut->addHTML( '&#160;'.Xml::listDropDown( 'timezone', $this->dropDownList( range ( -12, 14, 1 ) ), '', $this->timezone, '', 1 ).' '.wfMsg( 'fundraiserstats-utc' ) );
 214+ // TODO: Fix timezone feature to work with caching correctly.
 215+ // $wgOut->addHTML( wfMsg( 'fundraiserstats-time-zone' ).'<br/>' );
 216+ // $wgOut->addHTML( '&#160;'.Xml::listDropDown( 'timezone', $this->dropDownList( range ( -12, 14, 1 ) ), '', $this->timezone, '', 1 ).' '.wfMsg( 'fundraiserstats-utc' ) );
211217 $wgOut->addHTML( Xml::closeElement( 'div' ) );
212218
213219 $wgOut->addHTML( Xml::closeElement( 'form' ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r103627MFT r103371, r103460, r103519, r103626awjrichards23:40, 18 November 2011

Status & tagging log