r103627 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103626‎ | r103627 | r103628 >
Date:23:40, 18 November 2011
Author:awjrichards
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/ContributionReporting (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ContributionReporting/ContributionReporting.i18n.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ContributionReporting/ContributionReporting.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ContributionReporting/ContributionTrackingStatistics_body.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ContributionReporting/FundraiserStatistics_body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/ContributionReporting/ContributionReporting.php
@@ -103,10 +103,9 @@
104104 $egFundraiserStatisticsMaximum = 10000;
105105
106106 // Cache timeout for fundraiser statistics, in seconds
107 -$egFundraiserStatisticsCacheTimeout = 300; // 5 minutes
 107+$egFundraiserStatisticsCacheTimeout = 900; // 15 minutes
108108
109109
110 -
111110 $wgContributionTrackingStatisticsViewWeeks = 3;
112111
113112 $wgHooks['ParserFirstCallInit'][] = 'efContributionReportingSetup';
Property changes on: branches/wmf/1.18wmf1/extensions/ContributionReporting/ContributionReporting.php
___________________________________________________________________
Modified: svn:mergeinfo
114113 Merged /trunk/extensions/ContributionReporting/ContributionReporting.php:r103626
Index: branches/wmf/1.18wmf1/extensions/ContributionReporting/ContributionTrackingStatistics_body.php
@@ -251,13 +251,9 @@
252252 );
253253
254254 foreach ( $res as $row ) {
255 - $result[] = array(
256 - $row[0],
257 - $row[1],
258 - $row[2],
259 - $row[3],
260 - $row[4]
261 - );
 255+ foreach( $row as $key => $value ) {
 256+ $result[] = $value;
 257+ }
262258 }
263259 return $result;
264260 }
Property changes on: branches/wmf/1.18wmf1/extensions/ContributionReporting/ContributionTrackingStatistics_body.php
___________________________________________________________________
Modified: svn:mergeinfo
265261 Merged /trunk/extensions/ContributionReporting/ContributionTrackingStatistics_body.php:r103460,103519,103626
Index: branches/wmf/1.18wmf1/extensions/ContributionReporting/FundraiserStatistics_body.php
@@ -22,7 +22,12 @@
2323 if ( $wgRequest->wasPosted() ) {
2424 $showYear[$fundraiser['id']] = $wgRequest->getCheck( 'toogle'.$fundraiser['id'] );
2525 } else {
26 - $showYear[$fundraiser['id']] = true;
 26+ // By default, show only the fundraising years after 2008
 27+ if ( intval( $fundraiser['id'] ) > 2008 ) {
 28+ $showYear[$fundraiser['id']] = true;
 29+ } else {
 30+ $showYear[$fundraiser['id']] = false;
 31+ }
2732 }
2833 }
2934
@@ -205,8 +210,9 @@
206211 }
207212 $wgOut->addHTML( Xml::openElement( 'div', array( 'id' => 'configholder' ) ) );
208213 $wgOut->addHTML( $years );
209 - $wgOut->addHTML( wfMsg( 'fundraiserstats-time-zone' ).'<br/>' );
210 - $wgOut->addHTML( '&#160;'.Xml::listDropDown( 'timezone', $this->dropDownList( range ( -12, 14, 1 ) ), '', $this->timezone, '', 1 ).' '.wfMsg( 'fundraiserstats-utc' ) );
 214+ // TODO: Fix timezone feature to work with caching correctly.
 215+ // $wgOut->addHTML( wfMsg( 'fundraiserstats-time-zone' ).'<br/>' );
 216+ // $wgOut->addHTML( '&#160;'.Xml::listDropDown( 'timezone', $this->dropDownList( range ( -12, 14, 1 ) ), '', $this->timezone, '', 1 ).' '.wfMsg( 'fundraiserstats-utc' ) );
211217 $wgOut->addHTML( Xml::closeElement( 'div' ) );
212218
213219 $wgOut->addHTML( Xml::closeElement( 'form' ) );
Property changes on: branches/wmf/1.18wmf1/extensions/ContributionReporting/FundraiserStatistics_body.php
___________________________________________________________________
Modified: svn:mergeinfo
214220 Merged /trunk/extensions/ContributionReporting/FundraiserStatistics_body.php:r103626
Index: branches/wmf/1.18wmf1/extensions/ContributionReporting/ContributionReporting.i18n.php
@@ -2521,6 +2521,7 @@
25222522 /** Hungarian (Magyar)
25232523 * @author Bdamokos
25242524 * @author Dani
 2525+ * @author Dj
25252526 * @author Enbéká
25262527 * @author Glanthor Reviol
25272528 * @author Misibacsi
@@ -2592,6 +2593,7 @@
25932594 'fundraiserstats-tab-averages' => 'Átlagosan (USD)',
25942595 'fundraiserstats-tab-maximums' => 'Maximum (USD)',
25952596 'fundraiserstats-tab-ytd' => 'Ebben az évben a mai napig (USD)',
 2597+ 'fundraiserstats-time-zone' => 'Időzóna:',
25962598 );
25972599
25982600 /** Interlingua (Interlingua)
@@ -3588,7 +3590,7 @@
35893591 'contribstats-template' => 'Шаблон',
35903592 'contribstats-nodata' => 'Нема внесено податоци',
35913593 'contribstats-landingpage' => 'Целна страница',
3592 - 'contribstats-donatepage' => 'Страница за донирање',
 3594+ 'contribstats-donatepage' => 'Страница за дарување',
35933595 'contribstats-average' => 'Просечно',
35943596 'contribstats-imperfect-data' => 'Овие податоци не се апсолутно точни бидејќи следењето на дарители без да се користи следење на сесии има свои ограничувања.',
35953597 'contribstats-paypal-donations' => 'Прилози преку PayPal',
Property changes on: branches/wmf/1.18wmf1/extensions/ContributionReporting/ContributionReporting.i18n.php
___________________________________________________________________
Modified: svn:mergeinfo
35963598 Merged /trunk/extensions/ContributionReporting/ContributionReporting.i18n.php:r103371,103460,103519,103626
Property changes on: branches/wmf/1.18wmf1/extensions/ContributionReporting
___________________________________________________________________
Modified: svn:mergeinfo
35973599 Merged /trunk/extensions/ContributionReporting:r103371,103460,103519,103626

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103371Localisation updates for core and extension messages from translatewiki.netraymond20:05, 16 November 2011
r103460Attempt to fix the way result data is populated after seeing...mah14:02, 17 November 2011
r103519Localisation updates for core and extension messages from translatewiki.netraymond22:50, 17 November 2011
r103626disabling timezone stuff for nowkaldari23:30, 18 November 2011

Status & tagging log