r103423 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103422‎ | r103423 | r103424 >
Date:00:26, 17 November 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Swapped the file exclusion list to array and iterate over that to make the argument array

Also exclude tiff from Diff
Modified paths:
  • /trunk/tools/make-release/make-release (modified) (history)

Diff [purge]

Index: trunk/tools/make-release/make-release
@@ -174,7 +174,9 @@
175175 dir2 += '/languages/messages'
176176 else:
177177 print "Generating normal patch file..."
178 - args.extend(['-x', 'messages', '-x', '*.png', '-x', '*.jpg', '-x', '*.xcf', '-x', '*.gif', '-x', '*.svg'])
 178+ excludedExtensions = ['messages', '*.png', '*.jpg', '*.xcf', '*.gif', '*.svg', '*.tiff']
 179+ for ext in excludedExtensions:
 180+ args.extend(['-x', ext])
179181
180182 args.extend([dir1, dir2])
181183 print ' '.join(args)

Comments

#Comment by Nikerabbit (talk | contribs)   09:55, 15 December 2011

"messages" is not an extension is it?

#Comment by Reedy (talk | contribs)   12:43, 15 December 2011

Heh, not quite. Probably should rename the variable

Status & tagging log