r103422 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103421‎ | r103422 | r103423 >
Date:00:21, 17 November 2011
Author:yaron
Status:deferred
Tags:
Comment:
Another follow-up to r102888 - changed parameter from 'imagepreview' to 'image preview', added class to <div> tag around preview image
--This line, And those below, will be ignored--

M forminputs/SF_TextInput.php
Modified paths:
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextInput.php
@@ -62,7 +62,7 @@
6363
6464 $cssClasses = array( 'sfFancyBox', 'sfUploadable' );
6565
66 - $showPreview = array_key_exists( 'imagepreview', $other_args );
 66+ $showPreview = array_key_exists( 'image preview', $other_args );
6767
6868 if ( $showPreview ) {
6969 $cssClasses[] = 'sfImagePreview';
@@ -97,7 +97,7 @@
9898
9999 $text .= Html::rawElement(
100100 'div',
101 - array( 'id' => $input_id . '_imagepreview' ),
 101+ array( 'id' => $input_id . '_imagepreview', 'class' => 'sfImagePreviewWrapper' ),
102102 $previewImage
103103 );
104104 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102888added image preview stuffjeroendedauw11:48, 13 November 2011