r103062 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103061‎ | r103062 | r103063 >
Date:23:01, 14 November 2011
Author:raindrift
Status:ok
Tags:
Comment:
added config flag for disabling chunked uploads while leaving the FormData transport active
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.config.php (modified) (history)
  • /trunk/extensions/UploadWizard/resources/mw.FormDataTransport.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizard.config.php
@@ -415,6 +415,9 @@
416416 'enableFormData' => true,
417417
418418 // should multi-file select be available in supporting browsers?
419 - 'enableMultiFileSelect' => true
 419+ 'enableMultiFileSelect' => true,
420420
 421+ // should chunked uploading be enabled? false for now since the backend isn't really ready.
 422+ 'enableChunked' => false,
 423+
421424 );
Index: trunk/extensions/UploadWizard/resources/mw.FormDataTransport.js
@@ -31,7 +31,7 @@
3232 file = this.uploadObject.file,
3333 bytesAvailable = file.size;
3434
35 - if(file.size > this.chunkSize) {
 35+ if( mw.UploadWizard.config[ 'enableChunked' ] && file.size > this.chunkSize ) {
3636 this.uploadChunk(0);
3737 } else {
3838 this.xhr = new XMLHttpRequest();

Follow-up revisions

RevisionCommit summaryAuthorDate
r103068MFT r103062 -- add config flag to turn off chunked APIneilk23:16, 14 November 2011

Status & tagging log