r103061 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103060‎ | r103061 | r103062 >
Date:22:57, 14 November 2011
Author:bsitu
Status:resolved (Comments)
Tags:
Comment:
this fixes bug32108 - Adding server side check for empty comment
Modified paths:
  • /trunk/extensions/MoodBar/FeedbackItem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/FeedbackItem.php
@@ -193,7 +193,7 @@
194194 } elseif ( $key == 'type' ) {
195195 return in_array( $value, self::$validTypes );
196196 } elseif ( $key == 'comment' ) {
197 - $comment_len = mb_strlen( $value );
 197+ $comment_len = mb_strlen( $value );
198198 return $comment_len > 0 && $comment_len <= 140;
199199 }
200200

Follow-up revisions

RevisionCommit summaryAuthorDate
r103205Removing unnecessary space in FeedbackItem.php line 196bsitu18:26, 15 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103057Moodbar phase 1 bug fixes, fixes bug32108 and addresses others in FeedbackDas...rmoen22:40, 14 November 2011
r103060Bug 32108 - Adding server side check for empty commentbsitu22:51, 14 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   11:07, 15 November 2011

Comment does not match change, which only adds unnecessary space.

#Comment by Bsitu (talk | contribs)   18:30, 15 November 2011

Removed the unnecessary space in revision r103205, which reverts r103061 back to r103060

Status & tagging log