r102954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102953‎ | r102954 | r102955 >
Date:09:16, 14 November 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Fix for r102949: don't delete too much
Modified paths:
  • /trunk/phase3/maintenance/fixExtLinksProtocolRelative.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/fixExtLinksProtocolRelative.php
@@ -70,7 +70,7 @@
7171 )
7272 ), __METHOD__, array( 'IGNORE' )
7373 );
74 - $db->delete( 'externallinks', array( 'el_index' => $row->el_index ), __METHOD__ );
 74+ $db->delete( 'externallinks', array( 'el_index' => $row->el_index, 'el_from' => $row->el_from, 'el_to' => $row->el_to ), __METHOD__ );
7575 }
7676 $this->output( "Done, $count rows updated.\n" );
7777 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r103029REL1_18 MFT r99236, r102301, r102303, r102498, r102710, r102751, r102951, r10...reedy20:58, 14 November 2011
r103056MFT r102951, r102954reedy22:40, 14 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102951(bug 29854) Store protocol-relative links twice in the externallinks table, o...catrope09:13, 14 November 2011

Comments

#Comment by Catrope (talk | contribs)   09:18, 14 November 2011

I meant r102951

Status & tagging log