r102710 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102709‎ | r102710 | r102711 >
Date:22:54, 10 November 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
on tablesort, verify <caption> is the first child in the table

r102303 tried to compare the whole table when bug 32047 only require
we have <caption> as a first child. Easier definition leads to easier
code!
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
@@ -393,19 +393,13 @@
394394 '<tr class="sortbottom"><td>TFOOT</td></tr>' +
395395 '</table>'
396396 );
397 - //console.log( $table.html() );
398397 $table.tablesorter();
399 - //console.log( $table.html() );
400 - var expected =
401 - '<caption>CAPTION</caption>'+
402 - '<thead>' +
403 - '<tr><th title=\"&lt;sort-ascending&gt;\" class=\"headerSort\">THEAD</th></tr>' +
404 - '</thead>' +
405 - '<tbody><tr><td>A</td></tr>' +
406 - '<tr><td>B</td></tr>' +
407 - '<tr class=\"sortbottom\"><td>TFOOT</td></tr>' +
408 - '</tbody><tfoot></tfoot>';
409 - deepEqual( $table.html(), expected, '<caption> must be placed before <thead> (bug 32047)' );
 398+
 399+ equals(
 400+ $table.children( ).get( 0 ).nodeName,
 401+ 'CAPTION',
 402+ 'First element after <thead> must be <caption> (bug 32047)'
 403+ );
410404 });
411405
412406 test( 'data-sort-value attribute, when available, should override sorting position', function() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r103029REL1_18 MFT r99236, r102301, r102303, r102498, r102710, r102751, r102951, r10...reedy20:58, 14 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102301Fix Bug #32047: in table with class="sortable", thead is before...mah17:33, 7 November 2011
r102303tests for bug 32047 / r102301...hashar17:48, 7 November 2011
r102498Comments out console.log calls...hashar09:01, 9 November 2011

Comments

#Comment by Hashar (talk | contribs)   23:19, 10 November 2011

Seems to fix testswarm for now (Opera / Firefox at least)

Status & tagging log