r102792 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102791‎ | r102792 | r102793 >
Date:15:33, 11 November 2011
Author:bawolff
Status:ok
Tags:
Comment:
Follow-up r102751 - I think this test was intermitently failing because it was re-using thumbs generated for previous tests. Add a random number to stop that.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/media/ExifRotationTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/media/ExifRotationTest.php
@@ -11,7 +11,7 @@
1212 $this->handler = new BitmapHandler();
1313 $this->repo = new FSRepo(array(
1414 'name' => 'temp',
15 - 'directory' => wfTempDir() . '/exif-test-' . time(),
 15+ 'directory' => wfTempDir() . '/exif-test-' . time() . '-' . mt_rand(),
1616 'url' => 'http://localhost/thumbtest'
1717 ));
1818 if ( !wfDl( 'exif' ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r103900MFT r102792demon14:51, 22 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102751(follow-up r99910) Make $wgEnableAutoRotation work...bawolff04:09, 11 November 2011

Status & tagging log