r102791 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102790‎ | r102791 | r102792 >
Date:15:29, 11 November 2011
Author:catrope
Status:ok
Tags:
Comment:
[RL2] Followup r102789, whitespace
Modified paths:
  • /branches/RL2/extensions/Gadgets/Gadgets.hooks.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/Gadgets.hooks.php
@@ -288,7 +288,7 @@
289289 'default' => $gadget->isEnabledForUser( $user ),
290290 // HTMLForm is very strict about the names/IDs it accepts
291291 // So specify a custom name that we know is safe and won't change
292 - 'name' => 'gadgetpref-' . md5($id),
 292+ 'name' => 'gadgetpref-' . md5( $id ),
293293 );
294294 } else {
295295 $preferences["gadget-$id"] = array(
@@ -297,7 +297,7 @@
298298 // TODO the below means source and category IDs can't contain slashes or dashes, enforce this
299299 'section' => "gadgetsshared/gadgetrepo-$repoSource$sectionCat",
300300 'cssclass' => 'mw-gadgets-shared-pref',
301 - 'name' => 'gadgetpref-' . md5($id),
 301+ 'name' => 'gadgetpref-' . md5( $id ),
302302 // 'default' isn't in here by design: we don't want
303303 // enabledByDefault to be honored across wikis
304304 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102789[RL2] Use custom names and IDs for gadgets on the preferences page, and set t...catrope15:19, 11 November 2011

Status & tagging log