r102566 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102565‎ | r102566 | r102567 >
Date:20:29, 9 November 2011
Author:jhsoby
Status:ok (Comments)
Tags:
Comment:
Adding bt-button and rt-button to interface messages.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/interface.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/interface.i18n.php
——@@ -126,6 +126,8 @@
127127 'donate_interface-paypal-button' => 'Donate via PayPal',
128128 'donate_interface-cc-button' => 'Donate by credit card',
129129 'donate_interface-dd-button' => 'Donate by direct debit',
 130+ 'donate_interface-bt-button' => 'Donate by bank transfer',
 131+ 'donate_interface-rt-button' => 'Donate via bank using $1',
130132 'donate_interface-donor-legend' => 'Donor information',
131133 'donate_interface-card-legend' => 'Credit card information',
132134 'donate_interface-amount-legend' => 'Donation amount',
——@@ -515,8 +517,12 @@
516518 'donate_interface-accessible' => 'Error message if you try to go to "Special:PayFlowProGateway" from anywhere else than the donation form.',
517519 'donate_interface-paypal-button' => 'Button to choose to donate via PayPal.',
518520 'donate_interface-cc-button' => 'Button to choose to donate by credit card.',
519 - 'donate_interface-dd-button' => 'Button to choose to donate by direct debit.',
520 - 'donate_interface-donor-legend' => 'Header for the entire form where you fill out your personal information.',
 521+ 'donate_interface-dd-button' => 'Button to choose to donate by [[w:direct debit|direct debit]].',
 522+ 'donate_interface-bt-button' => 'Button to choose to donate by bank transfer.',
 523+ 'donate_interface-rt-button' => "Button to choose to donate via real time banking.
 524+
 525+'''\$1''' is the name of a bank that performs such actions. E.g. \"IDEAL\" for the Netherlands or \"Nordea\" for Sweden. Will only be used in select countries.',
 526+ 'donate_interface-donor-legend' => 'Header for the entire form where you fill out your personal information.",
521527 'donate_interface-card-legend' => 'Header for part of the form that has information about the credit card itself.',
522528 'donate_interface-amount-legend' => 'Where you choose what amount to donate.',
523529 'donate_interface-cvv-link' => 'Text for the link to show the user where to find the [[Wikipedia:Card security code|security code]] on their credit card.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r102597MFT r102323, r102424, r102438, r102563, r102566awjrichards23:18, 9 November 2011
r102608MFT r102117, r102141, r102145, r102146, r102154, r102167, r102169, r102195, r...awjrichards23:43, 9 November 2011
r102664Spaces to tabs....platonides15:53, 10 November 2011

Comments

#Comment by Jpostlethwaite (talk | contribs)   22:37, 9 November 2011

Why are there two new lines in the qqq section for (around line 522):

donate_interface-rt-button

#Comment by Platonides (talk | contribs)   22:48, 9 November 2011

Because he wanted the newlines in the message?

It's nice to see you here, Jon.

You're using spaces, they should be tabs. Note that escaping the $ does no harm, but isn't necessary as a number can't begin a variable name.

I find "Donate via bank" a bit strange, wouldn't "Donate through $1 bank" be more appropiate?

#Comment by Jpostlethwaite (talk | contribs)   23:06, 9 November 2011

Do the new lines get turned into extra line breaks somewhere for documentation?

#Comment by Platonides (talk | contribs)   23:55, 9 November 2011

Yes. The qqq messages are shown in translatewiki.net

#Comment by Jon Harald Søby (talk | contribs)   01:55, 10 November 2011

Tabs, of course; I'm so used to editing in wiki environments that I practically forgot that tabs actually exist. :P Will keep that in mind from now on. I only escaped the $ because that was how it was done in other qqq messages, so I figured that even if it wasn't necessarily necessary, it wouldn't do any harm.

As for that message, I have no strong preference, though I agree that your suggestion sounds better. We could even just drop 'bank' (many banks have 'bank' in their name, so that could lead to redundancies).

For line breaks, I did what other qqq messages had where they have line breaks, so that should be all right too.

#Comment by Platonides (talk | contribs)   15:56, 10 November 2011

No, it doesn't do any harm. It was just for reference, asi it's usually easier to write them without escaping.

I changed the spaces to tabs in r102664. Also changed to what I suggested, given that you liked it. I considered dropping 'bank', but as it makes easier to understand the context (esp. for translations), and the samples don't have bank in their name i kept that word. I find preferable a bit of redundancy than people wondering what's that "ideal donation system".

#Comment by Mormegil (talk | contribs)   14:05, 25 May 2012

The more interesting thing is that the “donate_interface-rt-button” message is unterminated – it has mismatched quotation characters, beginning with a double quote, ending with a single quote. But then, “donate_interface-donor-legend” has the opposite problem, meaning to wrongs make a right, and everything is quite fine. :-)

(The message documentation has already been fixed using TranslateWiki.net.)

Status & tagging log