r102420 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102419‎ | r102420 | r102421 >
Date:18:33, 8 November 2011
Author:preilly
Status:deferred (Comments)
Tags:mobile 
Comment:
prevent autocorrect and capitalization
Modified paths:
  • /trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php
@@ -25,7 +25,7 @@
2626 <form action='{$scriptUrl}' class='search_bar' method='get' {$searchBoxDisplayNone}>
2727 <input type="hidden" value="Special:Search" name="title" />
2828 <div id="sq" class="divclearable">
29 - <input type="text" name="search" id="search" size="22" value="{$searchField}" autocomplete="off" />
 29+ <input type="text" name="search" id="search" size="22" value="{$searchField}" autocorrect="off" autocomplete="off" autocapitalize="off" maxlength="1024" />
3030 <div class="clearlink" id="clearsearch"></div>
3131 </div>
3232 <button id='goButton' type='submit'></button>

Follow-up revisions

RevisionCommit summaryAuthorDate
r1024471.18wmf1: MFT r102420, r102431preilly21:21, 8 November 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   01:33, 13 December 2011

Hm, is autocorrect/autocomplete so awful in the search bar? Sounds like that would be something I would want to stay there...

#Comment by 😂 (talk | contribs)   16:16, 5 January 2012

I could see it going either way...I could very well be searching for a word that's not in my phone's dictionary and it tries to autocorrect me.

#Comment by Brion VIBBER (talk | contribs)   17:54, 5 January 2012

Seems like the phone's input system already has a way to let you override, so why interfere?

Status & tagging log