r102447 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102446‎ | r102447 | r102448 >
Date:21:21, 8 November 2011
Author:preilly
Status:deferred
Tags:
Comment:
1.18wmf1: MFT r102420, r102431
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/MobileFrontend/views/layout/_search_webkit.html.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/MobileFrontend/views/layout/application.html.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/MobileFrontend/views/layout/_search_webkit.html.php
@@ -10,11 +10,11 @@
1111 $scriptUrl = wfScript();
1212 $searchBoxDisplayNone = ( self::$hideSearchBox ) ? ' style="display: none;" ' : '';
1313
14 -$openSearchResults = ( self::$isBetaGroupMember ) ? '<div id="results"></div>' : '';
 14+$openSearchResults = '<div id="results"></div>';
1515
1616 $languageSelection = self::buildLanguageSelection() . '<br/>';
1717 $languageSelectionText = '<b>' . self::$messages['mobile-frontend-language'] . ':</b><br/>';
18 -$languageSelectionDiv = ( self::$isBetaGroupMember ) ? '<div id="languageselectionsection">' . $languageSelectionText . $languageSelection . '</div>' : '';
 18+$languageSelectionDiv = '<div id="languageselectionsection">' . $languageSelectionText . $languageSelection . '</div>';
1919
2020 $logoOnClick = ( self::$device['supports_javascript'] ) ? 'onclick="javascript:logoClick();"' : '';
2121
@@ -25,7 +25,7 @@
2626 <form action='{$scriptUrl}' class='search_bar' method='get' {$searchBoxDisplayNone}>
2727 <input type="hidden" value="Special:Search" name="title" />
2828 <div id="sq" class="divclearable">
29 - <input type="text" name="search" id="search" size="22" value="{$searchField}" autocomplete="off" />
 29+ <input type="text" name="search" id="search" size="22" value="{$searchField}" autocorrect="off" autocomplete="off" autocapitalize="off" maxlength="1024" />
3030 <div class="clearlink" id="clearsearch"></div>
3131 </div>
3232 <button id='goButton' type='submit'></button>
Index: branches/wmf/1.18wmf1/extensions/MobileFrontend/views/layout/application.html.php
@@ -18,7 +18,7 @@
1919 $endScriptTag = '"></script>';
2020 $javaScriptPath = $wgExtensionAssetsPath . '/MobileFrontend/javascripts/';
2121
22 -$openSearchScript = ( self::$isBetaGroupMember ) ? $startScriptTag . $javaScriptPath . 'opensearch.js?version=11022011124437' . $endScriptTag : '';
 22+$openSearchScript = $startScriptTag . $javaScriptPath . 'opensearch.js?version=11082011124437' . $endScriptTag;
2323
2424 $applicationHtml = <<<EOT
2525 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102420prevent autocorrect and capitalizationpreilly18:33, 8 November 2011
r102431remove is beta group member check on new featurespreilly19:49, 8 November 2011

Status & tagging log