r102172 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102171‎ | r102172 | r102173 >
Date:12:15, 6 November 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Didn't we agree to use @since?
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -996,6 +996,7 @@
997997
998998 /**
999999 * HTML-escaped version of getCanonicalURL()
 1000+ * @since 1.18
10001001 */
10011002 public function escapeCanonicalURL( $query = '', $variant = false ) {
10021003 return htmlspecialchars( $this->getCanonicalURL( $query, $variant ) );
@@ -1032,6 +1033,7 @@
10331034 * @param $query string An optional query string
10341035 * @param $variant string Language variant of URL (for sr, zh, ...)
10351036 * @return string The URL
 1037+ * @since 1.18
10361038 */
10371039 public function getCanonicalURL( $query = '', $variant = false ) {
10381040 $url = wfExpandUrl( $this->getLocalURL( $query, $variant ) . $this->getFragmentForURL(), PROTO_CANONICAL );

Comments

#Comment by Catrope (talk | contribs)   12:37, 8 November 2011

I'm sorry! :(

#Comment by Nikerabbit (talk | contribs)   12:42, 8 November 2011

Aww, there is this nice proverb in Finnish for your comfort: Rapatessa roiskuu [1].

Status & tagging log