r102173 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102172‎ | r102173 | r102174 >
Date:12:25, 6 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r102160

Also, bad werdna
Modified paths:
  • /trunk/extensions/Cite/Cite.php (modified) (history)
  • /trunk/extensions/ReferenceTooltips/ReferenceTooltips.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ReferenceTooltips/ReferenceTooltips.php
@@ -36,10 +36,8 @@
3737 'position' => 'bottom',
3838 );
3939
40 -function rtfBeforePageDisplay() {
41 - global $wgOut;
42 -
43 - $wgOut->addModules( 'ext.reference-tooltips' );
44 -
 40+function rtfBeforePageDisplay( $out, &$sk ) {
 41+ $out->addModules( 'ext.reference-tooltips' );
 42+
4543 return true;
4644 }
Index: trunk/extensions/Cite/Cite.php
@@ -48,7 +48,7 @@
4949
5050 /**
5151 * Performs the hook registration.
52 - * Note that several extensions (and even core!) try to detect if Cite is
 52+ * Note that several extensions (and even core!) try to detect if Cite is
5353 * installed by looking for wfCite().
5454 *
5555 * @param $parser Parser
@@ -80,13 +80,10 @@
8181 'position' => 'bottom',
8282 );
8383
84 -function wfCiteBeforePageDisplay() {
85 - global $wgOut;
86 -
87 - $wgOut->addModules( 'ext.cite' );
88 -
 84+function wfCiteBeforePageDisplay( $out, &$sk ) {
 85+ $out->addModules( 'ext.cite' );
 86+
8987 return true;
9088 }
9189
92 -
9390 /**#@-*/

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100797Commit ReferenceTooltips extension. It gives the content of a reference as a ...werdna07:58, 26 October 2011
r102160Merging ReferenceTooltips into Cite step 2: rename/registermaxsem08:02, 6 November 2011

Status & tagging log