r101532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101531‎ | r101532 | r101533 >
Date:21:36, 1 November 2011
Author:tparscal
Status:resolved (Comments)
Tags:
Comment:
Updated language as per requests from WMF legal department.
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -599,7 +599,7 @@
600600 }, mw.msg('articlefeedback-form-panel-helpimprove-privacy')
601601 );
602602 return mw.html.escape( mw.msg( 'articlefeedback-form-panel-helpimprove-note') )
603 - .replace( /\$1/, mw.message( 'parentheses', link ).toString() );
 603+ .replace( /\$1/, link );
604604 })
605605 .end()
606606 .find( '.articleFeedback-helpimprove-email' )
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -26,7 +26,7 @@
2727 'articlefeedback-survey-submit' => 'Submit',
2828 'articlefeedback-survey-title' => 'Please answer a few questions',
2929 'articlefeedback-survey-thanks' => 'Thanks for filling out the survey.',
30 - 'articlefeedback-survey-disclaimer' => 'To help improve this feature, your feedback may be shared anonymously with the Wikipedia community.',
 30+ 'articlefeedback-survey-disclaimer' => 'By submitting, you agree to transparency under these [http://wikimediafoundation.org/wiki/Feedback_privacy_statement terms]',
3131 /* ext.articleFeedback and jquery.articleFeedback */
3232 'articlefeedback-error' => 'An error has occured. Please try again later.',
3333 'articlefeedback-form-switch-label' => 'Rate this page',
@@ -40,10 +40,10 @@
4141 'articlefeedback-form-panel-expertise-hobby' => 'It is a deep personal passion',
4242 'articlefeedback-form-panel-expertise-other' => 'The source of my knowledge is not listed here',
4343 'articlefeedback-form-panel-helpimprove' => 'I would like to help improve Wikipedia, send me an e-mail (optional)',
44 - 'articlefeedback-form-panel-helpimprove-note' => 'We will send you a confirmation e-mail. We will not share your address with anyone. $1',
 44+ 'articlefeedback-form-panel-helpimprove-note' => 'We will send you a confirmation e-mail. We will not share your email with outside parties as per our $1.',
4545 'articlefeedback-form-panel-helpimprove-email-placeholder' => 'email@example.org', // Optional
46 - 'articlefeedback-form-panel-helpimprove-privacy' => 'Privacy policy',
47 - 'articlefeedback-form-panel-helpimprove-privacylink' => 'Project:Privacy policy',
 46+ 'articlefeedback-form-panel-helpimprove-privacy' => 'feedback privacy statement',
 47+ 'articlefeedback-form-panel-helpimprove-privacylink' => 'http://wikimediafoundation.org/wiki/Feedback_privacy_statement',
4848 'articlefeedback-form-panel-submit' => 'Submit ratings',
4949 'articlefeedback-form-panel-pending' => 'Your ratings have not been submitted yet',
5050 'articlefeedback-form-panel-success' => 'Saved successfully',

Follow-up revisions

RevisionCommit summaryAuthorDate
r101539Follow-up r101532: email -> e-mail address.siebrand21:58, 1 November 2011
r101611Fix r101532 which was so broken that I refuse to believe it was tested even o...catrope10:54, 2 November 2011
r1016601.18wmf1: Merge stuff for editor engagement deployment...catrope19:01, 2 November 2011

Comments

#Comment by P858snake (talk | contribs)   08:44, 15 December 2011

Although this is a mostly a WMF extension (at least currently), It would probably be nicer if we didn't include messages in it that defaulted to pointing at foundation wiki

Status & tagging log