r101608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101607‎ | r101608 | r101609 >
Date:10:20, 2 November 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Removed BC code not needed any longer
Modified paths:
  • /trunk/extensions/Translate/api/ApiQueryMessageCollection.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/api/ApiQueryMessageCollection.php
@@ -117,19 +117,10 @@
118118 }
119119
120120 public function getAllowedParams() {
121 -
122 - // Ugly code for BC <= 1.16
123 - $class = new ReflectionClass( 'ApiBase' );
124 - if ( $class->hasConstant( 'PARAM_REQUIRED' ) ) {
125 - $required = ApiBase::PARAM_REQUIRED;
126 - } else {
127 - $required = 8;
128 - }
129 -
130121 return array(
131122 'group' => array(
132123 ApiBase::PARAM_TYPE => array_keys( MessageGroups::getAllGroups() ),
133 - $required => true,
 124+ ApiBase::PARAM_REQUIRED => true;
134125 ),
135126 'language' => array(
136127 ApiBase::PARAM_TYPE => 'string',

Follow-up revisions

RevisionCommit summaryAuthorDate
r101610Followup r101608 - fix syntax errornikerabbit10:35, 2 November 2011

Status & tagging log