r101609 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101608‎ | r101609 | r101610 >
Date:10:26, 2 November 2011
Author:ialex
Status:ok
Tags:
Comment:
Per Roan, fix for r101491: set to false instead of unsetting to avoid notice
Modified paths:
  • /trunk/extensions/Collection/Collection.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.hooks.php
@@ -52,10 +52,8 @@
5353 global $wgCollectionPortletForLoggedInUsersOnly;
5454
5555 if ( !$wgCollectionPortletForLoggedInUsersOnly || $wgUser->isLoggedIn() ) {
56 - if ( isset( $navUrls['print'] ) ) {
57 - // We move this guy out to our own box
58 - unset( $navUrls['print'] );
59 - }
 56+ // We move this guy out to our own box
 57+ $navUrls['print'] = false;
6058 }
6159 return true;
6260 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101491* Create all items in $nav_urls at the beginning so that we don't need to bot...ialex16:09, 1 November 2011

Status & tagging log