r101581 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101580‎ | r101581 | r101582 >
Date:03:56, 2 November 2011
Author:cryptocoryne
Status:deferred (Comments)
Tags:
Comment:
bug 32056
Modified paths:
  • /branches/REL1_17/extensions/CentralAuth/SpecialGlobalGroupMembership.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/CentralAuth/SpecialGlobalGroupMembership.php
——@@ -9,7 +9,7 @@
1010 var $mGlobalUser;
1111
1212 function __construct() {
13 - parent::__construct( 'GlobalGroupMembership' );
 13+ SpecialPage::__construct( 'GlobalGroupMembership' );
1414
1515 global $wgUser;
1616 $this->mGlobalUser = CentralAuthUser::getInstance( $wgUser );

Comments

#Comment by Nikerabbit (talk | contribs)   09:02, 2 November 2011

The mentioned bug is still open?

#Comment by Cryptocoryne (talk | contribs)   10:32, 2 November 2011

The mentioned bug contains not only this issue. About other issues/requests I've write to brion, as author of CentralAuth extension.

#Comment by Johnduhart (talk | contribs)   14:21, 2 November 2011 
-		parent::__construct( 'GlobalGroupMembership' );
+		SpecialPage::__construct( 'GlobalGroupMembership' );

This seems very wrong, why are you changing this?

#Comment by Cryptocoryne (talk | contribs)   19:30, 2 November 2011

This code used in current trunk and wmf versions of CentralAuth (1.19-svn, 1.18). GlobalGroupMembership extends UserRights class and __parent::construct() call this function from UserRights class ("parent::__construct( 'Userrights' )"), but not from SpecialPage class.

With old code this page is can't work on my installation (redirected to Special:UserRights). Also see bug 32056 and r81942. After changing this line of code the Special page is normally working.

Status & tagging log