r81942 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81941‎ | r81942 | r81943 >
Date:09:24, 11 February 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Partial revert r71963: this should call the SpecialPage constructor, not parent
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php
——@@ -9,7 +9,7 @@
1010 var $mGlobalUser;
1111
1212 function __construct() {
13 - parent::__construct( 'GlobalGroupMembership' );
 13+ SpecialPage::__construct( 'GlobalGroupMembership' );
1414
1515 global $wgUser;
1616 $this->mGlobalUser = CentralAuthUser::getInstance( $wgUser );

Follow-up revisions

RevisionCommit summaryAuthorDate
r821411.17wmf1: MFT r81942catrope20:34, 14 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71963More php4 constructors. Missed these somehowdemon17:18, 30 August 2010

Comments

#Comment by 😂 (talk | contribs)   09:24, 11 February 2011

This was originally in GlobalUserrights, but it got moved into CentralAuth at some point. Live hack already in place.

#Comment by Bryan (talk | contribs)   09:27, 11 February 2011

Can't SpecialUserrights::__construct() just accept an optional parameter to pass to its parent?

Status & tagging log