r101210 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101209‎ | r101210 | r101211 >
Date:21:55, 28 October 2011
Author:aaron
Status:ok
Tags:
Comment:
(bug 32024) - Don't pass 'false' to $this->pager->setLimit()
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/specialpages/reports/PendingChanges_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/specialpages/reports/PendingChanges_body.php
@@ -38,7 +38,9 @@
3939 $this->feed( $feedType );
4040 } else {
4141 if ( $this->including() ) {
42 - $this->pager->setLimit( $incLimit ); // apply non-URL limit
 42+ if ( $incLimit ) { // limit provided
 43+ $this->pager->setLimit( $incLimit ); // apply non-URL limit
 44+ }
4345 } else {
4446 $this->setSyndicated();
4547 $this->showForm();

Follow-up revisions

RevisionCommit summaryAuthorDate
r101213MFT r101210 - 'Don't pass 'false' to $this->pager->setLimit()'aaron21:57, 28 October 2011

Status & tagging log