r101213 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101212‎ | r101213 | r101214 >
Date:21:57, 28 October 2011
Author:aaron
Status:ok
Tags:
Comment:
MFT r101210 - 'Don't pass 'false' to $this->pager->setLimit()'
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/FlaggedRevs/presentation/specialpages/reports/PendingChanges_body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/FlaggedRevs/presentation/specialpages/reports/PendingChanges_body.php
@@ -36,7 +36,9 @@
3737 $this->feed( $feedType );
3838 } else {
3939 if ( $this->including() ) {
40 - $this->pager->setLimit( $incLimit ); // apply non-URL limit
 40+ if ( $incLimit ) { // limit provided
 41+ $this->pager->setLimit( $incLimit ); // apply non-URL limit
 42+ }
4143 } else {
4244 $this->setSyndicated();
4345 $this->showForm();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101210(bug 32024) - Don't pass 'false' to $this->pager->setLimit()aaron21:55, 28 October 2011

Status & tagging log