r101190 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101189‎ | r101190 | r101191 >
Date:20:37, 28 October 2011
Author:siebrand
Status:ok
Tags:live 
Comment:
1.18wmf1 hack: make all URLs to CR revisions in CR e-mails https.

Ugly hack discussed with Roan:
[8:09p] siebrand: Any objections against this live hack in 1.18wmf1 code review for CR mails?
[8:09p] siebrand: CodeRevision.php, line 448: $rowUrl = $revision->getCanonicalUrl();
[8:09p] siebrand: // Live hack: always make the URL use https:
[8:09p] siebrand: $rowUrl = str_replace( 'http:', 'https:', $rowUrl );
[8:10p] RoanKattouw: Eww
[8:10p] siebrand: it's not getting fixed, and I am getting seriously annoyed by it; couldn't find a more elegant solution...
[8:17p] siebrand: RoanKattouw: what's the better fix?
[8:17p] siebrand: RoanKattouw: (that's not going to take weeks until someone has time to do the rework)
[8:17p] RoanKattouw: The live hack will be fine then
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CodeReview/backend/CodeRevision.php
——@@ -447,6 +447,9 @@
448448
449449 $rowUrl = $revision->getCanonicalUrl();
450450
 451+ // Live hack: always make the URL use https:
 452+ $rowUrl = str_replace( 'http:', 'https:', $rowUrl );
 453+
451454 $revisionAuthor = $revision->getWikiUser();
452455
453456 $revisionCommitSummary = $revision->getMessage();

Follow-up revisions

RevisionCommit summaryAuthorDate
r101206Follow-up r101190: more http -> https (for e-mail and IRC)siebrand21:38, 28 October 2011

Status & tagging log