r101206 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101205‎ | r101206 | r101207 >
Date:21:38, 28 October 2011
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up r101190: more http -> https (for e-mail and IRC)
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CodeReview/backend/CodeRevision.php
@@ -441,6 +441,9 @@
442442 // Get repo and build comment title (for url)
443443 $url = $this->getCanonicalUrl();
444444
 445+ // Live hack: always make the URL use https:
 446+ $url = str_replace( 'http:', 'https:', $url );
 447+
445448 foreach ( $res as $row ) {
446449 $revision = CodeRevision::newFromRow( $this->repo, $row );
447450 $users = $revision->getCommentingUsers();
@@ -628,6 +631,9 @@
629632
630633 $url = $this->getCanonicalUrl( $commentId );
631634
 635+ // Live hack: always make the URL use https:
 636+ $url = str_replace( 'http:', 'https:', $url );
 637+
632638 $this->sendCommentToUDP( $commentId, $text, $url );
633639
634640 return $commentId;
@@ -1267,6 +1273,9 @@
12681274 if( $wgCodeReviewUDPAddress ) {
12691275 if( is_null( $url ) ) {
12701276 $url = $this->getCanonicalUrl( $commentId );
 1277+
 1278+ // Live hack: always make the URL use https:
 1279+ $url = str_replace( 'http:', 'https:', $url );
12711280 }
12721281
12731282 $line = wfMsg( 'code-rev-message' ) . " \00314(" . $this->repo->getName() .
@@ -1287,6 +1296,9 @@
12881297 if( $wgCodeReviewUDPAddress ) {
12891298 $url = $this->getCanonicalUrl();
12901299
 1300+ // Live hack: always make the URL use https:
 1301+ $url = str_replace( 'http:', 'https:', $url );
 1302+
12911303 $line = wfMsg( 'code-rev-status' ) . " \00314(" . $this->repo->getName() .
12921304 ")\00303 " . RecentChange::cleanupForIRC( $wgUser->getName() ) . "\003 " .
12931305 /* Remove three apostrophes as they are intended for the parser */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r1011901.18wmf1 hack: make all URLs to CR revisions in CR e-mails https....siebrand20:37, 28 October 2011

Status & tagging log