r101188 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101187‎ | r101188 | r101189 >
Date:20:17, 28 October 2011
Author:johnduhart
Status:deferred (Comments)
Tags:
Comment:
Followup r101143, fix double escaping
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBarHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBarHooks.php
——@@ -67,7 +67,7 @@
6868 return true;
6969 }
7070
71 - $modetext = wfMessage( 'onlinestatusbar-status-' . $status )->escaped();
 71+ $modetext = wfMessage( 'onlinestatusbar-status-' . $status )->toString();
7272 $image = OnlineStatusBar::getImageHtml( $status );
7373 $text = wfMessage( 'onlinestatusbar-line', $user->getName() )
7474 ->rawParams( $image )->params( $modetext )->escaped();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101143Followup r101137, Adding ->escape to a wfMessage() call that was missingjohnduhart15:52, 28 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:23, 29 October 2011

toString defaults to parsing if I remember correctly, so it is still double escaping. I would use ->plain() here.

Status & tagging log