r101143 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101142‎ | r101143 | r101144 >
Date:15:52, 28 October 2011
Author:johnduhart
Status:deferred (Comments)
Tags:
Comment:
Followup r101137, Adding ->escape to a wfMessage() call that was missing
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBarHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBarHooks.php
@@ -64,7 +64,7 @@
6565 return true;
6666 }
6767
68 - $modetext = wfMessage( 'onlinestatusbar-status-' . $status ) ;
 68+ $modetext = wfMessage( 'onlinestatusbar-status-' . $status )->escaped();
6969 $image = OnlineStatusBar::getImageHtml( $status );
7070 $text = wfMessage( 'onlinestatusbar-line', $user->getName() )
7171 ->rawParams( $image )->params( $modetext )->escaped();

Follow-up revisions

RevisionCommit summaryAuthorDate
r101188Followup r101143, fix double escapingjohnduhart20:17, 28 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101137Code improvements and cleanup to OnlineStatusBarjohnduhart15:12, 28 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   18:35, 28 October 2011

This looks like double escaping to me.

Status & tagging log