r101177 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101176‎ | r101177 | r101178 >
Date:19:17, 28 October 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Followup r101161 having array() doesn't work so well with isset, changing to null
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
——@@ -134,7 +134,7 @@
135135 */
136136 static public $preloadedKeys = array( 'dateFormats', 'namespaceNames' );
137137
138 - var $mergeableKeys = array();
 138+ var $mergeableKeys = null;
139139
140140 /**
141141 * Constructor.

Follow-up revisions

RevisionCommit summaryAuthorDate
r101879Fix fixme on r101177reedy20:55, 3 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101161More documentation updatesreedy18:11, 28 October 2011

Comments

#Comment by 😂 (talk | contribs)   00:49, 3 November 2011

Per the coding conventions doc, "Do not use isset() to check for null"

#Comment by Reedy (talk | contribs)   20:56, 3 November 2011

Slightly amusing as this was what the code was doing before (r101161 added explicit definition), and would've been 0

Fixed nonetheless

Status & tagging log