r101879 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101878‎ | r101879 | r101880 >
Date:20:55, 3 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix fixme on r101177
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -196,7 +196,7 @@
197197 * @return bool
198198 */
199199 public function isMergeableKey( $key ) {
200 - if ( !isset( $this->mergeableKeys ) ) {
 200+ if ( $this->mergeableKeys === null ) {
201201 $this->mergeableKeys = array_flip( array_merge(
202202 self::$mergeableMapKeys,
203203 self::$mergeableListKeys,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101177Followup r101161 having array() doesn't work so well with isset, changing to ...reedy19:17, 28 October 2011

Status & tagging log