r101084 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101083‎ | r101084 | r101085 >
Date:23:15, 27 October 2011
Author:reedy
Status:ok
Tags:
Comment:
For some reason cc_review is being pulled. God knows...
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeComment.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -752,7 +752,6 @@
753753 'cc_user' => $wgUser->getId(),
754754 'cc_user_text' => $wgUser->getName(),
755755 'cc_timestamp' => $dbw->timestamp( $ts ),
756 - 'cc_review' => $review,
757756 'cc_sortkey' => $sortkey );
758757 }
759758
@@ -807,7 +806,6 @@
808807 'cc_user_text',
809808 'cc_patch_line',
810809 'cc_timestamp',
811 - 'cc_review',
812810 'cc_sortkey' ),
813811 $conditions,
814812 __METHOD__,
Index: trunk/extensions/CodeReview/backend/CodeComment.php
@@ -4,7 +4,7 @@
55 * Represents a comment made to a revision.
66 */
77 class CodeComment {
8 - public $id, $text, $user, $userText, $timestamp, $review, $sortkey, $attrib, $removed, $added, $patchLine;
 8+ public $id, $text, $user, $userText, $timestamp, $sortkey, $attrib, $removed, $added, $patchLine;
99
1010 /**
1111 * @var CodeRevision
@@ -48,7 +48,6 @@
4949 'cc_user_text',
5050 'cc_patch_line',
5151 'cc_timestamp',
52 - 'cc_review',
5352 'cc_sortkey'
5453 ),
5554 array( 'cc_id' => (int) $cc_id ),
@@ -70,7 +69,6 @@
7170 $comment->userText = $data['cc_user_text'];
7271 $comment->timestamp = wfTimestamp( TS_MW, $data['cc_timestamp'] );
7372 $comment->patchLine = $data['cc_patch_line'];
74 - $comment->review = $data['cc_review'];
7573 $comment->sortkey = $data['cc_sortkey'];
7674 return $comment;
7775 }

Sign-offs

UserFlagDate
Nikerabbitinspected07:38, 28 October 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r101085MFT r101084reedy23:17, 27 October 2011

Status & tagging log