r101085 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101084‎ | r101085 | r101086 >
Date:23:17, 27 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CodeReview (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CodeReview/backend/CodeComment.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CodeReview/backend/CodeRevision.php
@@ -700,7 +700,6 @@
701701 'cc_user' => $wgUser->getId(),
702702 'cc_user_text' => $wgUser->getName(),
703703 'cc_timestamp' => $dbw->timestamp( $ts ),
704 - 'cc_review' => $review,
705704 'cc_sortkey' => $sortkey );
706705 }
707706
@@ -742,7 +741,6 @@
743742 'cc_user',
744743 'cc_user_text',
745744 'cc_timestamp',
746 - 'cc_review',
747745 'cc_sortkey' ),
748746 array(
749747 'cc_repo_id' => $this->repoId,
Property changes on: branches/wmf/1.18wmf1/extensions/CodeReview/backend/CodeRevision.php
___________________________________________________________________
Modified: svn:mergeinfo
750748 Merged /trunk/extensions/CodeReview/backend/CodeRevision.php:r101084
Index: branches/wmf/1.18wmf1/extensions/CodeReview/backend/CodeComment.php
@@ -1,7 +1,7 @@
22 <?php
33
44 class CodeComment {
5 - public $id, $text, $user, $userText, $timestamp, $review, $sortkey, $attrib, $removed, $added;
 5+ public $id, $text, $user, $userText, $timestamp, $sortkey, $attrib, $removed, $added;
66
77 /**
88 * @var CodeRevision
@@ -36,7 +36,6 @@
3737 $comment->user = $data['cc_user'];
3838 $comment->userText = $data['cc_user_text'];
3939 $comment->timestamp = wfTimestamp( TS_MW, $data['cc_timestamp'] );
40 - $comment->review = $data['cc_review'];
4140 $comment->sortkey = $data['cc_sortkey'];
4241 return $comment;
4342 }
Property changes on: branches/wmf/1.18wmf1/extensions/CodeReview
___________________________________________________________________
Modified: svn:mergeinfo
4443 Merged /trunk/extensions/CodeReview:r101084

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101084For some reason cc_review is being pulled. God knows...reedy23:15, 27 October 2011

Status & tagging log