r100876 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100875‎ | r100876 | r100877 >
Date:21:23, 26 October 2011
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
fix fail
Modified paths:
  • /trunk/extensions/SemanticResultFormats/GoogleCharts/SRF_GoogleBar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/GoogleCharts/SRF_GoogleBar.php
——@@ -82,7 +82,7 @@
8383 // $params['height']->addMessage( 'srf_paramdesc_chartheight' );
8484
8585 $params['width'] = new Parameter( 'height', Parameter::TYPE_INTEGER, 250 );
86 - $params['width']->addMessage( 'srf_paramdesc_chartwidth' );
 86+ $params['width']->setMessage( 'srf_paramdesc_chartwidth' );
8787
8888 return $params;
8989 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r100999Follow up to r100912; r100876jeroendedauw16:40, 27 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   06:35, 27 October 2011

Should you also fix the commented code above? ;)

#Comment by Jeroen De Dauw (talk | contribs)   14:38, 27 October 2011

Huh? It's commented out, since it's not supported for now. How would I fix that?

#Comment by Nikerabbit (talk | contribs)   15:01, 27 October 2011

I mean, you could make the same change, assuming the code would have the same bug if uncommented.