r100999 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100998‎ | r100999 | r101000 >
Date:16:40, 27 October 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
Follow up to r100912; r100876
Modified paths:
  • /trunk/extensions/SemanticResultFormats/GoogleCharts/SRF_GoogleBar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/GoogleCharts/SRF_GoogleBar.php
@@ -71,12 +71,10 @@
7272 }
7373
7474 public function getParameters() {
75 - $this->supportsGroupBy = true;
76 -
7775 $params = parent::getParameters();
7876
7977 // $params['height'] = new Parameter( 'height', Parameter::TYPE_INTEGER, 250 );
80 -// $params['height']->addMessage( 'srf_paramdesc_chartheight' );
 78+// $params['height']->setMessage( 'srf_paramdesc_chartheight' );
8179
8280 $params['width'] = new Parameter( 'width', Parameter::TYPE_INTEGER, 250 );
8381 $params['width']->setMessage( 'srf_paramdesc_chartwidth' );
@@ -85,4 +83,3 @@
8684 }
8785
8886 }
89 -

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100876fix failjeroendedauw21:23, 26 October 2011
r100912kill obsolete bc codejeroendedauw00:16, 27 October 2011

Status & tagging log