r100839 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100838‎ | r100839 | r100840 >
Date:18:43, 26 October 2011
Author:awjrichards
Status:ok
Tags:fundraising 
Comment:
Fixing redundat loadResources() call in TwoStepTwoColumnLetter3 form because the parent will already load the correct resources
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php
@@ -8,18 +8,8 @@
99 if ( !strlen( $this->getStylePath() ) ) {
1010 $this->setStylePath( $wgExtensionAssetsPath . '/DonationInterface/gateway_forms/css/TwoStepTwoColumnLetter3.css' );
1111 }
12 - $this->loadvalidateJs();
1312 parent::__construct( $gateway, $form_errors );
1413 }
15 -
16 - /**
17 - * Load resources required by this form
18 - *
19 - * @see parent::loadResources()
20 - */
21 - public function loadResources() {
22 - $this->loadValidateJs();
23 - }
2414
2515 public function loadPlaceholders() {
2616 global $wgOut;

Follow-up revisions

RevisionCommit summaryAuthorDate
r100843Revert r100839. I misunderstood what exactly loadPlaceholders was already doi...awjrichards18:56, 26 October 2011

Status & tagging log