r100697 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100696‎ | r100697 | r100698 >
Date:14:10, 25 October 2011
Author:hashar
Status:resolved (Comments)
Tags:
Comment:
tweak CodeReview email notifications

I have spent way too much time trying to quickly read the notification
emails we receive from mw.org. Those new messages are a bit more
readeable to me.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
——@@ -151,58 +151,58 @@
152152 'codereview-overview-desc' => 'Show a graphical overview of this list',
153153
154154 'codereview-email-subj' => '[$1 $2]: New comment added',
155 - 'codereview-email-body' => 'User "$1" posted a comment on $3.
 155+ 'codereview-email-body' => '"$1" posted a comment on $3.
 156+URL: $2
156157
157 -Full URL: $2
158 -Commit summary:
 158+Commit summary for $3:
159159
160160 $5
161161
162 -Comment:
 162+$1\'s comment:
163163
164164 $4',
165165
166166 'codereview-email-subj2' => '[$1 $2]: Follow-up changes',
167 - 'codereview-email-body2' => 'User "$1" made follow-up changes to $2.
 167+ 'codereview-email-body2' => '"$1" made follow-up changes to $2.
 168+URL: $5
168169
169 -Full URL for followed up revision: $5
170 -Commit summary:
 170+Commit summary for followed-up $2:
171171
172172 $6
173173
174 -Full URL: $3
175 -Commit summary:
 174+Follow-up URL: $3
 175+Follow-up summary by "$1":
176176
177177 $4',
178178
179179 'codereview-email-subj3' => '[$1 $2]: Revision status changed',
180 - 'codereview-email-body3' => 'User "$1" changed the status of $2.
 180+ 'codereview-email-body3' => '"$1" changed the status of $2 to "$4"
 181+URL: $5
181182
182 -Old Status: $3
183 -New Status: $4
 183+Old status: $3
 184+> New status: $4
184185
185 -Full URL: $5
186 -Commit summary:
 186+Commit summary for $2:
187187
188188 $6',
189189
190190 'codereview-email-subj4' => '[$1 $2]: New comment added, and revision status changed',
191 - 'codereview-email-body4' => 'User "$1" changed the status of $2.
 191+ 'codereview-email-body4' => '"$1" changed the status of $2 to "$4" and commented it.
 192+URL: $5
192193
193194 Old Status: $3
194 -New Status: $4
 195+> New Status: $4
195196
196 -User "$1" also posted a comment on $2.
 197+Commit summary for $2:
197198
198 -Full URL: $5
199 -Commit summary:
200 -
201199 $7
202200
203 -Comment:
 201+$1\'s comment:
204202
205 -$6',
 203+$6
206204
 205+',
 206+
207207 'code-stats' => 'statistics',
208208 'code-stats-header' => 'Statistics for repository $1',
209209 'code-stats-main' => 'As of $1, the repository has $2 {{PLURAL:$2|revision|revisions}} by [[Special:Code/$3/author|$4 {{PLURAL:$4|author|authors}}]].',

Follow-up revisions

RevisionCommit summaryAuthorDate
r105245[i18n] partial revert of r100697 per CR...krinkle23:29, 5 December 2011

Comments

#Comment by Krinkle (talk | contribs)   22:09, 5 December 2011 
-Old Status: $3
-New Status: $4
+Old status:  $3
+> New status: $4

This > character is causing e-mail clients to render this as a "quote". Sometimes (GMail) it's actually collapsed, requiring me to expand the (supposedly) repeated section in order to read it. If this was not intentional, please undo it.

Example: http://i.imgur.com/luQCU.png

#Comment by Hashar (talk | contribs)   23:21, 5 December 2011

This was intentional.

The idea is that lot of clients use a different colors for quoted lines use a different color. Thus it highlight the change. Gmail collapsing defeat the purpose. I am wondering if quote collapsing can be disabled under a given threshold.

#Comment by Krinkle (talk | contribs)   23:23, 5 December 2011

Sounds like a work-around to me, is this necessary ? If we want nice visual emails we can use HTML. If just plain text, I'd prefer just keeping it plain.

Status & tagging log