r100698 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100697‎ | r100698 | r100699 >
Date:14:30, 25 October 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
New log translationreview.
Made with the old logging system, but made as much forward compatible as possible.
Internationalization/#142
Modified paths:
  • /trunk/extensions/Translate/Translate.i18n.php (modified) (history)
  • /trunk/extensions/Translate/Translate.php (modified) (history)
  • /trunk/extensions/Translate/TranslateHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/Translate.php
@@ -139,6 +139,13 @@
140140 $wgGroupPermissions['translate-proofr']['translate-messagereview'] = true;
141141 $wgAddGroups['translate-proofr'] = array( 'translate-proofr' );
142142
 143+// Logs
 144+$wgLogTypes[] = 'translationreview';
 145+$wgLogActionsHandlers['translationreview/message'] = 'TranslateHooks::formatTranslationreviewLogEntry';
 146+// BC for <1.19
 147+$wgLogHeaders['pagetranslation'] = 'log-description-translationreview';
 148+$wgLogNames['pagetranslation'] = 'log-name-translationreview';
 149+
143150 // New jobs
144151 $wgJobClasses['MessageIndexRebuildJob'] = 'MessageIndexRebuildJob';
145152
Index: trunk/extensions/Translate/TranslateHooks.php
@@ -312,5 +312,22 @@
313313 return true;
314314 }
315315
 316+ /// Log action handler
 317+ public static function formatTranslationreviewLogEntry( $type, $action, $title, $forUI, $params ) {
 318+ global $wgLang, $wgContLang;
316319
 320+ $language = $forUI === null ? $wgContLang : $wgLang;
 321+ $linker = class_exists( 'DummyLinker' ) ? new DummyLinker : new Linker;
 322+
 323+ if ( $action === 'message' ) {
 324+ return wfMessage( 'logentry-translationreview-message' )->params(
 325+ '', // User link in the new system
 326+ '#', // User name for gender in the new system
 327+ Message::rawParam( $linker->link( $title, null, array(), array( 'oldid' => $params[0] ) ) )
 328+ )->inLanguage( $language )->text();
 329+ }
 330+ return '';
 331+ }
 332+
 333+
317334 }
Index: trunk/extensions/Translate/Translate.i18n.php
@@ -389,6 +389,11 @@
390390 'group-translate-proofr-member' => '{{GENDER:$1|translation reviewer}}',
391391 'grouppage-translate-proofr' => '{{ns:project}}:Translation reviewers',
392392
 393+ // Less damn for the 32 character limit for log names
 394+ 'log-name-translationreview' => 'Translation review log',
 395+ 'log-description-translationreview' => 'Log of all reviews to translations and message groups.',
 396+ 'logentry-translationreview-message' => '$1 {{GENDER:$2|reviewed}} translation $3',
 397+
393398 );
394399
395400 /** Message documentation (Message documentation)

Status & tagging log